Form general or special questions with the question word given.
1) We have been friends since childhood. (since when) 2) The rain hasn't stopped yet. (general) 3) The film has been on for a week (for how long) 4) He had recovered by the time I returned from my leave. (general) 5) He will have worked as a teacher for 20 years by next Semptember. (for how long) 6) The students will have started the discussion by the time you come. (who)

Спасибо, а как вы думаете general questions правильно ли я составила: 2) Has the rain stopped yet? 4) Had he recovered by the time I returned from my leave?

Да

1) Since when have we been friends?2) -3) For how long has the film been on? 4) -5) For how long will he have been working by next September? 6) Who will start the discussion by the time you come?